Migrate to GitHub Actions #358
Conversation
athomas
force-pushed
the
github-actions
branch
from
5e3f9b1 to
3ff0711
Compare
|
@kevmoo Any suggestions how to proceed here? I'm not sure why the tests are failing, but it seems to be Chrome 88 that's causing trouble here. Travis had successful builds on Chrome 87. Unless I'm missing something, perhaps we can land this and figure out the Chrome 88 issues once we're on Actions? |
|
I'm not sure who the main owner of intl is any more, either. Interesting to see if this test is running and passing internally |
|
Chatted with Alex; my team owns intl in google3, and syncing from google3->external as needed. google3 isn't on Chrome 88 yet, when it rolls we'll need to fix the test there. |
<public> Migrate to GitHub Actions Closes #358 </public> PiperOrigin-RevId: 355393492
|
I'd like to get #362 landed and published - we'll ignore the failing CI for that PR since we know we're publishing exactly what passed CI previously with the published prerelease version. That one will impact the sync but I don't think it will cause too much trouble. I'll land and internal CL with the same changes. I do think that after we get the publish done there should not be any blockers to land this PR. These files are not involved in the sync process, and don't introduce new failures. We have the problem of fixing the tests on the latest chrome either way, but doesn't specifically need to be tied to this PR. |
|
@natebosch I'm assuming that this is still on your plate. Let me know in case I misunderstood. |
<public> Migrate to GitHub Actions Closes #358 </public> PiperOrigin-RevId: 355393492
Changes: ``` > git log --format="%C(auto) %h %s" 9669926..9145f30 https://dart.googlesource.com/intl.git/+/9145f30 Bump actions/checkout from 2 to 3 (#462) https://dart.googlesource.com/intl.git/+/f545753 update the analysis_options.yaml file (#449) https://dart.googlesource.com/intl.git/+/fee2c2d Add a changelog entry for a recent feature (#406) https://dart.googlesource.com/intl.git/+/4e37662 GitHub Sync (#405) https://dart.googlesource.com/intl.git/+/0a14483 Bump dart-lang/setup-dart from 0.3 to 1 (#403) https://dart.googlesource.com/intl.git/+/f22f7b5 fix directive sorting https://dart.googlesource.com/intl.git/+/ed2fbe0 Add dependabot https://dart.googlesource.com/intl.git/+/2518923 Merge pull request #377 from dart-lang/franklinyow-patch-1 https://dart.googlesource.com/intl.git/+/bee0456 Update LICENSE https://dart.googlesource.com/intl.git/+/9bb4bcc Migrating to dart:ffi in Dart 2.12. https://dart.googlesource.com/intl.git/+/532a1e3 Migrating to `dart:ffi` in Dart 2.12 and `package:ffi` 1.0.0. https://dart.googlesource.com/intl.git/+/458129d Replace git dependencies with published versions https://dart.googlesource.com/intl.git/+/5fd7a11 COPYBARA CHANGE FOR dart-archive/intl#358 https://dart.googlesource.com/intl.git/+/2c8e014 Fix typo; see https://screenshot.googleplex.com/5afwL4iQtHeJKLC https://dart.googlesource.com/intl.git/+/33251e0 Prepare to publish for stable null safety (#362) https://dart.googlesource.com/intl.git/+/b3da438 Prep release for beta (#338) https://dart.googlesource.com/intl.git/+/48675cf Prepare a version of intl that supports the 2.12 sdk ``` Diff: https://dart.googlesource.com/intl.git/+/9669926609e7efc17dfd74fbb44ec719a7e573cc~..9145f308f1458f37630a1ffce3b7d3b471ebbc56/ Change-Id: Ic431da0e0785bd4ece86542fae30aad55f384f50 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245222 Commit-Queue: Devon Carew <devoncarew@google.com> Reviewed-by: Nate Bosch <nbosch@google.com>
<public> Migrate to GitHub Actions Closes dart-archive/intl#358 </public> PiperOrigin-RevId: 355393492
No description provided.